Skip to content

Commit

Permalink
feat: add component config
Browse files Browse the repository at this point in the history
Signed-off-by: rainfd <[email protected]>
  • Loading branch information
rainfd committed Jul 4, 2024
1 parent 7866d64 commit 7797b24
Show file tree
Hide file tree
Showing 20 changed files with 1,833 additions and 28 deletions.
8 changes: 8 additions & 0 deletions PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,12 @@ resources:
defaulting: true
validation: true
webhookVersion: v1
- api:
crdVersion: v1
namespaced: true
domain: jobset.x-k8s.io
group: jobset
kind: Configuration
path: sigs.k8s.io/jobset/api/config/v1alpha1
version: v1alpha1
version: "3"
133 changes: 133 additions & 0 deletions api/config/v1alpha1/configuration_types.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
/*
Copyright 2023 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package v1alpha1

import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
configv1alpha1 "k8s.io/component-base/config/v1alpha1"
)

// +k8s:defaulter-gen=true
// +kubebuilder:object:root=true

// Configuration is the Schema for the configurations API
type Configuration struct {
metav1.TypeMeta `json:",inline"`

// Namespace is the namespace in which jobset controller is deployed.
// It is used as part of DNSName of the webhook Service.
// If not set, the value is set from the file /var/run/secrets/kubernetes.io/serviceaccount/namespace
// If the file doesn't exist, default value is kueue-system.
Namespace *string `json:"namespace,omitempty"`

// ControllerManager returns the configurations for controllers
ControllerManager `json:",inline"`

// InternalCertManagerment is configuration for internalCertManagerment
InternalCertManagement *InternalCertManagement `json:"internalCertManagement,omitempty"`

ClientConnection *ClientConnection `json:"clientConnection,omitempty"`
}

type ControllerManager struct {
// Webhook contains the controllers webhook configuration
// +optional
Webhook ControllerWebhook `json:"webhook,omitempty"`

// LeaderElection is the LeaderElection config to be used when configuring
// the manager.Manager leader election
// +optional
LeaderElection *configv1alpha1.LeaderElectionConfiguration `json:"leaderElection,omitempty"`

// Metrics contains the controller metrics configuration
// +optional
Metrics ControllerMetrics `json:"metrics,omitempty"`

// Health contains the controller health configuration
// +optional
Health ControllerHealth `json:"health,omitempty"`
}

// ControllerWebhook defines the webhook server for the controller.
type ControllerWebhook struct {
// Port is the port that the webhook server serves at.
// It is used to set webhook.Server.Port.
// +optional
Port *int `json:"port,omitempty"`

// Host is the hostname that the webhook server binds to.
// It is used to set webhook.Server.Host.
// +optional
Host string `json:"host,omitempty"`

// CertDir is the directory that contains the server key and certificate.
// if not set, webhook server would look up the server key and certificate in
// {TempDir}/k8s-webhook-server/serving-certs. The server key and certificate
// must be named tls.key and tls.crt, respectively.
// +optional
CertDir string `json:"certDir,omitempty"`
}

// ControllerMetrics defines the metrics configs.
type ControllerMetrics struct {
// BindAddress is the TCP address that the controller should bind to
// for serving prometheus metrics.
// It can be set to "0" to disable the metrics serving.
// +optional
BindAddress string `json:"bindAddress,omitempty"`
}

// ControllerHealth defines the health configs.
type ControllerHealth struct {
// HealthProbeBindAddress is the TCP address that the controller should bind to
// for serving health probes
// It can be set to "0" or "" to disable serving the health probe.
// +optional
HealthProbeBindAddress string `json:"healthProbeBindAddress,omitempty"`

// ReadinessEndpointName, defaults to "readyz"
// +optional
ReadinessEndpointName string `json:"readinessEndpointName,omitempty"`

// LivenessEndpointName, defaults to "healthz"
// +optional
LivenessEndpointName string `json:"livenessEndpointName,omitempty"`
}

type InternalCertManagement struct {
// Enable controls whether to enable internal cert management or not.
// Defaults to true. If you want to use a third-party management, e.g. cert-manager,
// set it to false. See the user guide for more information.
Enable *bool `json:"enable,omitempty"`

// WebhookServiceName is the name of the Service used as part of the DNSName.
// Defaults to jobset-webhook-service.
WebhookServiceName *string `json:"webhookServiceName,omitempty"`

// WebhookSecretName is the name of the Secret used to store CA and server certs.
// Defaults to jobset-webhook-server-cert.
WebhookSecretName *string `json:"webhookSecretName,omitempty"`
}

type ClientConnection struct {
// QPS controls the number of queries per second allowed for K8S api server
// connection.
QPS *float32 `json:"qps,omitempty"`

// Burst allows extra queries to accumulate when a client is exceeding its rate.
Burst *int32 `json:"burst,omitempty"`
}
105 changes: 105 additions & 0 deletions api/config/v1alpha1/defaults.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
/*
Copyright 2022 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package v1alpha1

import (
"os"
"strings"
"time"

configv1alpha1 "k8s.io/component-base/config/v1alpha1"
"k8s.io/utils/ptr"
)

const (
DefaultNamespace = "jobset-system"
DefaultWebhookServiceName = "jobset-webhook-service"
DefaultWebhookSecretName = "jobset-webhook-server-cert"
DefaultWebhookPort = 9443
DefaultHealthProbeBindAddress = ":8081"
DefaultMetricsBindAddress = ":8080"
DefaultLeaderElectionID = "6d4f6a47.jobset.x-k8s.io"
DefaultLeaderElectionLeaseDuration = 15 * time.Second
DefaultLeaderElectionRenewDeadline = 10 * time.Second
DefaultLeaderElectionRetryPeriod = 2 * time.Second
DefaultResourceLock = "leases"
DefaultClientConnectionQPS float32 = 20.0
DefaultClientConnectionBurst int32 = 30
)

func getOperatorNamespace() string {
if data, err := os.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace"); err == nil {
if ns := strings.TrimSpace(string(data)); len(ns) > 0 {
return ns
}
}
return DefaultNamespace
}

// SetDefaults_Configuration sets default values for ComponentConfig.
//
//nolint:revive // format required by generated code for defaulting
func SetDefaults_Configuration(cfg *Configuration) {
if cfg.Namespace == nil {
cfg.Namespace = ptr.To(getOperatorNamespace())
}
if cfg.Webhook.Port == nil {
cfg.Webhook.Port = ptr.To(DefaultWebhookPort)
}
if len(cfg.Metrics.BindAddress) == 0 {
cfg.Metrics.BindAddress = DefaultMetricsBindAddress
}
if len(cfg.Health.HealthProbeBindAddress) == 0 {
cfg.Health.HealthProbeBindAddress = DefaultHealthProbeBindAddress
}

if cfg.LeaderElection == nil {
cfg.LeaderElection = &configv1alpha1.LeaderElectionConfiguration{}
}
if len(cfg.LeaderElection.ResourceName) == 0 {
cfg.LeaderElection.ResourceName = DefaultLeaderElectionID
}
if len(cfg.LeaderElection.ResourceLock) == 0 {
cfg.LeaderElection.ResourceLock = DefaultResourceLock
}
// Use the default LeaderElectionConfiguration options
configv1alpha1.RecommendedDefaultLeaderElectionConfiguration(cfg.LeaderElection)

if cfg.InternalCertManagement == nil {
cfg.InternalCertManagement = &InternalCertManagement{}
}
if cfg.InternalCertManagement.Enable == nil {
cfg.InternalCertManagement.Enable = ptr.To(true)
}
if *cfg.InternalCertManagement.Enable {
if cfg.InternalCertManagement.WebhookServiceName == nil {
cfg.InternalCertManagement.WebhookServiceName = ptr.To(DefaultWebhookServiceName)
}
if cfg.InternalCertManagement.WebhookSecretName == nil {
cfg.InternalCertManagement.WebhookSecretName = ptr.To(DefaultWebhookSecretName)
}
}
if cfg.ClientConnection == nil {
cfg.ClientConnection = &ClientConnection{}
}
if cfg.ClientConnection.QPS == nil {
cfg.ClientConnection.QPS = ptr.To(DefaultClientConnectionQPS)
}
if cfg.ClientConnection.Burst == nil {
cfg.ClientConnection.Burst = ptr.To(DefaultClientConnectionBurst)
}
}
Loading

0 comments on commit 7797b24

Please sign in to comment.