-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rootless: replace procfs workaround with KubeletInUserNamespace feature gate #2408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…re gate KubeletInUserNamespace feature gate was merged into Kubernetes v1.22, so we can drop the workaround to fake procfs. See: - kubernetes/kubernetes PR 92863 - https://kubernetes.io/docs/tasks/administer-cluster/kubelet-in-userns/ Signed-off-by: Akihiro Suda <[email protected]>
34e9a52
to
cb7eab3
Compare
New changes are detected. LGTM label has been removed. |
@AkihiroSuda: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
KubeletInUserNamespace feature gate was merged into Kubernetes v1.22, so we can drop the workaround to fake procfs.
See:
docker.io/akihirosuda/tmp-kind-base:g34e9a52a
docker.io/akihirosuda/tmp-kind-node:g34e9a52a-v1.22.0