Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootless: replace procfs workaround with KubeletInUserNamespace feature gate #2408

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Aug 8, 2021

KubeletInUserNamespace feature gate was merged into Kubernetes v1.22, so we can drop the workaround to fake procfs.

See:


  • Base: docker.io/akihirosuda/tmp-kind-base:g34e9a52a
  • Node: docker.io/akihirosuda/tmp-kind-node:g34e9a52a-v1.22.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2021
@AkihiroSuda AkihiroSuda closed this Aug 8, 2021
@AkihiroSuda AkihiroSuda reopened this Aug 8, 2021
@AkihiroSuda AkihiroSuda closed this Aug 8, 2021
@AkihiroSuda AkihiroSuda reopened this Aug 8, 2021
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
…re gate

KubeletInUserNamespace feature gate was merged into Kubernetes v1.22, so we can
drop the workaround to fake procfs.

See:
- kubernetes/kubernetes PR 92863
- https://kubernetes.io/docs/tasks/administer-cluster/kubelet-in-userns/

Signed-off-by: Akihiro Suda <[email protected]>
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

@AkihiroSuda: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kind-conformance-parallel-ipv6 cb7eab3 link /test pull-kind-conformance-parallel-ipv6
pull-kind-e2e-kubernetes cb7eab3 link /test pull-kind-e2e-kubernetes
pull-kind-conformance-parallel-ga-only cb7eab3 link /test pull-kind-conformance-parallel-ga-only

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@BenTheElder BenTheElder merged commit cb7eab3 into kubernetes-sigs:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants