-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug plugin #135
Add debug plugin #135
Conversation
Signed-off-by: Aylei <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aylei If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Aylei <[email protected]>
This name is too generic. Please choose something more unique and descriptive. Also there’s been a proposal to create an official debug command, which might be still going on: kubernetes/kubernetes#45922 |
Thank you for your advice! |
I agree Does this cause a problem with your documentation etc. Are you planning to go make the name change there as well? |
Not quite, I will add documents to explain the
I prefer not, changing name can be troublesome for me and existing adopters. |
Signed-off-by: Aylei <[email protected]>
I realize that I have to update some codes to support both |
Thanks! Expecting a new PR soon, happy to discuss what would be a more appropriate name. |
Hi there, thanks for reviewing my PR! Please don't hesitate to point out areas where I need to change.
Plugin Home Page
Signed-off-by: Aylei [email protected]
Checklist for plugin developers:
kubectl krew install --manifest=[...] --archive=[...]
)