Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release new version v0.9.0 of kueue #4190

Merged
merged 1 commit into from
Nov 13, 2024
Merged

release new version v0.9.0 of kueue #4190

merged 1 commit into from
Nov 13, 2024

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.9.0 of kueue on behalf of @mimowo.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Nov 5, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/kueue.yaml is not a straightforward version bump: change on line 3 does not seem like a version bump: [- - selector:]
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2024
@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Nov 6, 2024 •
edited
Loading

/lgtm

I also tested it with manual installation kubectl krew install --manifest=plugins/kueue.yaml.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2024
@mbobrovskyi
Copy link
Contributor

/cc @mimowo @ahmetb

@mbobrovskyi
Copy link
Contributor

@ahmetb PTAL 🙏

mimowo
mimowo reviewed Nov 13, 2024
View reviewed changes
Copy link

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also double checked all the checksums with sha256sum tool.
/assign @ahmetb

@ahmetb
Copy link
Member

ahmetb commented Nov 13, 2024

/lgtm
/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, krew-release-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit da4854c into kubernetes-sigs:master Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@ahmetb ahmetb Awaiting requested review from ahmetb

Assignees

@ahmetb ahmetb

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krew-release-bot @ahmetb @mbobrovskyi @k8s-ci-robot @mimowo