Merge pull request #1708 from camilamacedo86/fix-path-webhooks

🐛 check if resource exist to allow to create webhooks
kubernetes-sigs · Oct 13, 2020 · df80fc5 · df80fc5
2 parents 5031c94 + 77e00f8
commit df80fc5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/plugin/v2/webhook.go b/pkg/plugin/v2/webhook.go
@@ -96,6 +96,12 @@ func (p *createWebhookPlugin) Validate() error {
 			" --programmatic-validation and --conversion to be true", p.commandName)
 	}
 
+	// check if resource exist to create webhook
+	if !p.config.HasResource(p.resource.GVK()) {
+		return fmt.Errorf("%s create webhook requires an api with the group,"+
+			" kind and version provided", p.commandName)
+	}
+
 	return nil
 }
 

diff --git a/pkg/plugin/v3/webhook.go b/pkg/plugin/v3/webhook.go
@@ -96,6 +96,12 @@ func (p *createWebhookPlugin) Validate() error {
 			" --programmatic-validation and --conversion to be true", p.commandName)
 	}
 
+	// check if resource exist to create webhook
+	if !p.config.HasResource(p.resource.GVK()) {
+		return fmt.Errorf("%s create webhook requires an api with the group,"+
+			" kind and version provided", p.commandName)
+	}
+
 	return nil
 }