Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc suggestion: Mutating Webhooks can't set status #616

Closed
erictune opened this issue Mar 1, 2019 · 5 comments · Fixed by #3612
Closed

Doc suggestion: Mutating Webhooks can't set status #616

erictune opened this issue Mar 1, 2019 · 5 comments · Fixed by #3612
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@erictune
Copy link

erictune commented Mar 1, 2019

@akashrv @droot

Suggested additions to docs about admission webhooks:

"""Validating webhooks run after all mutating webhooks, so you don't need to worry about another webhook changing an object after your validation has accepted it."""

"""You cannot modify or default the status of a resource using a mutating admission webhook. Set initial status in your controller when you first see a new object."""

@droot droot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 6, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2019
@DirectXMan12
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2019
@DirectXMan12
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 9, 2019
@camilamacedo86 camilamacedo86 added this to the next milestone Nov 3, 2020
@ptnapoleon
Copy link

"""You cannot modify or default the status of a resource using a mutating admission webhook. Set initial status in your controller when you first see a new object."""

Is this true? Where does this limitation come from? This has worked in kubebuilder v2 for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants