-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 add info about status and webhooks #3612
📖 add info about status and webhooks #3612
Conversation
Hi @erictune, Could you please give a hand in the review of this one? |
/test pull-kubebuilder-e2e-k8s-1-25-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one comment on referencing upstream k8s documentation.
/lgtm
/approve
<aside class="note"> | ||
<H1>Execution Order</H1> | ||
|
||
**Validating webhooks run after all mutating webhooks**, so you don't need to worry about another webhook changing an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link this upstream documentation for more info on why mutating webhooks are invoked first: https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#what-are-admission-webhooks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Closes: #616