Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade controller-tools version from v0.2.5 to v0.3.0 #1482

Merged
merged 1 commit into from
May 7, 2020
Merged

upgrade controller-tools version from v0.2.5 to v0.3.0 #1482

merged 1 commit into from
May 7, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Apr 27, 2020 •
edited
Loading

Description
upgrade controller-tools version from v0.2.5 to v0.3.0

Motivation

  • avoid technical debts issues
  • get bug fix and improvements to support CRD and Webhook api V1.

PS.: Has no breaking changes. See: https://github.com/kubernetes-sigs/controller-tools/releases

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2020
@camilamacedo86
Copy link
Member Author

/test netlify/kubebuilder/deploy-preview

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubebuilder-test
  • /test pull-kubebuilder-e2e-k8s-1-17-0
  • /test pull-kubebuilder-e2e-k8s-1-16-2
  • /test pull-kubebuilder-e2e-k8s-1-15-3
  • /test pull-kubebuilder-e2e-k8s-1-14-1

Use /test all to run all jobs.

In response to this:

/test netlify/kubebuilder/deploy-preview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member Author

/test all

@camilamacedo86
Copy link
Member Author

/retest

@mengqiy
Copy link
Member

mengqiy commented May 1, 2020

After reading the log, it seems the netlify failed to build due to a too old golang was used.
It seems there is a way to use a newer golang version: https://community.netlify.com/t/go-version-1-13/5680
@camilamacedo86 can you try to fix this issue?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 1, 2020
@camilamacedo86 camilamacedo86 force-pushed the up-controller-gen branch 4 times, most recently from a272174 to 863a021 Compare May 3, 2020 13:04
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2020
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 4, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2020
@camilamacedo86 camilamacedo86 changed the title upgrade controller-tools version from v0.2.5 to v3.0.0 upgrade controller-tools version from v0.2.5 to v0.3.0 May 4, 2020
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-15-3

estroz
estroz reviewed May 4, 2020
View reviewed changes
docs/book/install-and-build.sh Outdated

# make sure we add the go bin directory to our path
echo "adding the go bin directory to our path"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change.

estroz
estroz reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit then LGTM

@camilamacedo86 camilamacedo86 mentioned this pull request May 6, 2020
Closed
@estroz
Copy link
Contributor

estroz commented May 7, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 09fca78 into kubernetes-sigs:master May 7, 2020
@camilamacedo86 camilamacedo86 deleted the up-controller-gen branch May 8, 2020 00:02
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz left review comments

@droot droot Awaiting requested review from droot

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @k8s-ci-robot @mengqiy @estroz