-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: organize templates in the same structure that they are scaffolded #1623
cleanup: organize templates in the same structure that they are scaffolded #1623
Conversation
12e9c55
to
2d8a76b
Compare
/test pull-kubebuilder-e2e-k8s-1-16-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny nits about grouping imports, otherwise this looks great!
2d8a76b
to
2c1b579
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pwittrock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubebuilder-e2e-k8s-1-14-1 |
/test pull-kubebuilder-e2e-k8s-1-15-3 |
Description
Organize templates aligned with the same structure that they are scaffolded
. ├── config │ ├── api │ │ ├── group.go │ │ ├── types.go │ │ └── webhook.go │ ├── certmanager │ │ ├── certificate.go │ │ ├── kustomize.go │ │ └── kustomizeconfig.go │ ├── controller │ │ ├── controller.go │ │ └── controller_suitetest.go │ ├── crd │ │ ├── enablecainjection_patch.go │ │ ├── enablewebhook_patch.go │ │ ├── kustomization.go │ │ └── kustomizeconfig.go │ ├── hack │ │ └── boilerplate.go │ ├── kdefault │ │ ├── auth_proxy_patch.go │ │ ├── enablecainection_patch.go │ │ ├── kustomize.go │ │ └── webhook_manager_patch.go │ ├── manager │ │ ├── config.go │ │ └── kustomization.go │ ├── prometheus │ │ ├── kustomize.go │ │ └── monitor.go │ ├── rbac │ │ ├── auth_proxy_role.go │ │ ├── auth_proxy_rolebinding.go │ │ ├── auth_proxy_service.go │ │ ├── client_cluster_role.go │ │ ├── crd_editor_rbac.go │ │ ├── crd_viewer_rbac.go │ │ ├── leader_election_role.go │ │ ├── leader_election_rolebinding.go │ │ ├── manager_role_binding.go │ │ └── rbac.go │ ├── samples │ │ └── crd_sample.go │ └── webhook │ ├── kustomization.go │ ├── kustomizeconfig.go │ └── service.go ├── dockerfile.go ├── dockerignorefile.go ├── gitignore.go ├── gomod.go ├── main.go └── makefile.go
Motivation
Keep it more intuitive for new contributors and easy to mantain.