Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Go module fullfillment for v2+ #1792

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 5, 2020

Targets #1791 for future versions

Fixes: #1562

It is not technically a breaking change but requires action from third-parties.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 5, 2020
@Adirio Adirio changed the title Go module fullfillment for v2+ ⚠️ Go module fullfillment for v2+ Nov 5, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Nov 6, 2020

/cc @droot @DirectXMan12 @mengqiy WDYT?

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the next release will be 3.0.0 and we cannot so longer push a patch release from master anyway then, IMO all here should be v3instead of v2. Otherwise, I am ok with the changes made.

c/c @pwittrock @estroz @DirectXMan12 wdyt?

@Adirio
Copy link
Contributor Author

Adirio commented Nov 6, 2020

Are we 100% certain next kubebuilder version is going to be 3.0.0? (Remember that I'm not talking about neither the kubebuilder base plugins nor the project configuration file version.)

I think that we are probably going to go to v3.0.0 next, but that there is still a chance to get a kubebuilder v2.4.0 version, and that's what I think that we should first bump to v2, and open an issue to track the change for the v3 milestone. It is just a search and replace at the end. The hard part is rebasing when files are moved.

Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Nov 7, 2020

I think that with #1798 tracking the change to v3, this can be merged. It requires lgtm.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2020
@camilamacedo86 camilamacedo86 removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2020
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit b22ff12 into kubernetes-sigs:master Nov 7, 2020
@Adirio Adirio deleted the modules-fullfillment branch November 7, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enh: go get of kubebuilder by tag doesn't work
4 participants