-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Go module fullfillment for v2+ #1792
⚠️ Go module fullfillment for v2+ #1792
Conversation
47e880b
to
17ddabb
Compare
/cc @droot @DirectXMan12 @mengqiy WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the next release will be 3.0.0 and we cannot so longer push a patch release from master anyway then, IMO all here should be v3
instead of v2
. Otherwise, I am ok with the changes made.
c/c @pwittrock @estroz @DirectXMan12 wdyt?
Signed-off-by: Adrian Orive <[email protected]>
17ddabb
to
01a20c9
Compare
Are we 100% certain next kubebuilder version is going to be 3.0.0? (Remember that I'm not talking about neither the kubebuilder base plugins nor the project configuration file version.) I think that we are probably going to go to v3.0.0 next, but that there is still a chance to get a kubebuilder v2.4.0 version, and that's what I think that we should first bump to v2, and open an issue to track the change for the v3 milestone. It is just a search and replace at the end. The hard part is rebasing when files are moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think that with #1798 tracking the change to |
/lgtm |
Targets #1791 for future versions
Fixes: #1562
It is not technically a breaking change but requires action from third-parties.