-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ change structure to store crdVersion and webhookversion (go/v3-alpha) #1899
⚠️ change structure to store crdVersion and webhookversion (go/v3-alpha) #1899
Conversation
730a830
to
32de34f
Compare
/test pull-kubebuilder-e2e-k8s-1-18-0 |
I think I'm ok with this. Going to wait for an ack from someone else. /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the Resource
and the Config
models need some cleanup, this PR moves the previously existing fields to their correct location, which means that the rest of the changes that are to be done in the near future will not be breaking changes from a project configutaion file perspective, so
\lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit in the comment. Apart from that LGTM
pkg/model/config/config.go
Outdated
} | ||
} | ||
|
||
// merge compares it with another webhook by setting each webhook type individually so existing values are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// merge compares it with another webhook by setting each webhook type individually so existing values are | |
// merge compares it with another api by setting each api type individually so existing values are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
32de34f
to
90a7ad3
Compare
/lgtm |
/test pull-kubebuilder-e2e-k8s-1-16-2 |
Description
Only does the changes required to store the new attributes crdVersion and webhookVersion in the format/layout define on #1772 and #1826.
Motivation