Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Filesystem and config persistence cleanup #1980

Closed
wants to merge 5 commits into from

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Jan 28, 2021

  • Uses a single filesystem:
    • Injected from cli to the scaffolders instead of creating multiple per scaffold.
    • Injected from cli to the config persistence layer instead of creating one per configuration representation.
  • Moves configuration creation, loading and saving operations to pre-/post-run hooks.
  • Cleans up subcommand binding methods.
  • Creates a new Store interface that abstracts the persistence layer used for Config.

Closes: #1936

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Adirio
To complete the pull request process, please assign pwittrock after the PR has been reviewed.
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Feb 4, 2021

This should probably be applied with plugin phase 1.5 described in #1990.

/hold

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2021
Use PreRunE and PostRunE functions to handle configuration file loading and saving

Signed-off-by: Adrian Orive <[email protected]>
…put Subcommand.UpdateMetadata

Signed-off-by: Adrian Orive <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Feb 8, 2021

Definetely closing this in favor of plugin phase 1.5 as implemented in #1991.

@Adirio Adirio closed this Feb 8, 2021
@Adirio Adirio deleted the filesystem branch February 8, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants