⚠️ Store abstraction for persisting Config #2057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This was referenced Mar 3, 2021
Closed
Closed
Adirio
force-pushed
the
config-store
branch
2 times, most recently
from
3ec8ac2
to
450aa15
Compare
- Use PreRunE and PostRunE functions to handle configuration file loading and saving - Use a filesystem provided by the cli to persist the project config and to scaffold files Signed-off-by: Adrian Orive <[email protected]>
k8s-ci-robot
added
the
needs-rebase
|
@Adirio: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closed in favor of #2083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports the project configuration scaffolding machinery through a
Storeinterface that has been implemented for the current YAML representation.PreRunEandPostRunEare used to handle configuration file loading and saving.Also, all the filesystem abstractions that were being created have been centralized to a single one provided by the CLI. This includes filesystem abstractions that were used for:
NOTE: the addition of the
Storeinterface and implementation is not a breaking change. However, the changes needed to inject the filesystem abstraction from the CLI to the different scaffolders does require to change certain interfaces.