Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Extend files whitelist for init cmd #2160

Merged
merged 1 commit into from
May 28, 2021
Merged

✨ Extend files whitelist for init cmd #2160

merged 1 commit into from
May 28, 2021

Conversation

w3st3ry
Copy link
Contributor

@w3st3ry w3st3ry commented Apr 28, 2021

Related to #2159

Signed-off-by: Valentin Pichard [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @w3st3ry!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @w3st3ry. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@w3st3ry
Copy link
Contributor Author

w3st3ry commented Apr 28, 2021

/assign @mengqiy

Adirio
Adirio previously requested changes Apr 28, 2021
View reviewed changes
pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
@w3st3ry w3st3ry force-pushed the fix-existing-files-whitelist branch from c7be33b to e82a221 Compare April 28, 2021 12:23
@w3st3ry w3st3ry requested a review from Adirio April 28, 2021 12:29
camilamacedo86
camilamacedo86 approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

@jmrodri @estroz @Adirio that seems fine for me. WDYT

pkg/plugins/golang/v3/init.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 11, 2021
jmrodri
jmrodri approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jmrodri: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jmrodri, w3st3ry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 dismissed Adirio’s stale review May 28, 2021 11:20

Adirio, it is blocked a while for you and waiting for response. (30days) Since it is very small and has others approvals as well and it will still not allowing PROJECT file which is the only capitalized one scaffolded it seems ok. So, I will move forward here, however, please feel free to ping us and let us know if you have any objection and suggestion and etc .. we can always do that in a follow up.

camilamacedo86
camilamacedo86 reviewed May 28, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6239034 into kubernetes-sigs:master May 28, 2021
@w3st3ry w3st3ry mentioned this pull request May 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@jmrodri jmrodri jmrodri approved these changes

@estroz estroz Awaiting requested review from estroz

@Adirio Adirio Awaiting requested review from Adirio

Assignees

@mengqiy mengqiy

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@w3st3ry @k8s-ci-robot @jmrodri @Adirio @camilamacedo86 @mengqiy