-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 prepare for 3.1.0 release #2189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue introduced in the redirect prep for v3 that broke our download redirects. The problem is that v3 releases are `kubebuilder_${os}_${arch}`, whereas v2 & v1 releases are `kubebuilder_${version}_${os}_${arch}.tar.gz`. Since netlify can't handle wildcards that are part of a path component (like `/2.:minorversion`) instead of a whole one (`:version`), we can't select on major version directly in our redirects. Instead, we introduce a function that handles this logic for us, and then use netlify 200-pseudo-redirects to "mount the function on the downloads part of the releases endpoint.
The local `netlify` dev server and documentation expect a top-level configuration block named functions, but the remote netlify builder expects a key under the build block instead. Who knows why.
…rrypick 📖 Netlify functions for download redirects
✨ bump controller-runtime to 0.8.3
Signed-off-by: Zou Yu <[email protected]>
The conversion webhook client config requires a list of conversion review versions. This change scaffolds the conversion webhook patch with default conversion review version of v1. Signed-off-by: varshaprasad96 <[email protected]>
🌱 Fix a gofmt warning
…rsions ✨ add default conversion review versions
Signed-off-by: Sujil02 <[email protected]>
✨ Use log from context
✨ Update go version in kubebuilder
Update tutorials in book to scaffold default conversion review version. Signed-off-by: varshaprasad96 <[email protected]>
📖 add default conversion review versions to kb book
k8s-ci-robot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
May 27, 2021
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
May 27, 2021
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
May 27, 2021
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
camilamacedo86
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Push the master changes to prepare for the next release 3.1.0
See that we have not too many changes, however, the next one is required to push the upper controller-runtime version.