Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ bump k8s dependencies to 1.21 #2208

Merged
merged 3 commits into from
Jul 1, 2021
Merged

✨ bump k8s dependencies to 1.21 #2208

merged 3 commits into from
Jul 1, 2021

Conversation

varshaprasad96
Copy link
Member

Bump k8s dependencies in kubebuilder binary to 1.21

Signed-off-by: varshaprasad96 [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2021
@varshaprasad96
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 9, 2021
@varshaprasad96
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@estroz
Copy link
Contributor

estroz commented Jun 9, 2021

@varshaprasad96 go/v3 projects need to use controller-runtime v0.9.0 too.

@varshaprasad96
Copy link
Member Author

varshaprasad96 commented Jun 9, 2021 •
edited
Loading

@estroz since there is a pr open on bumping controller-tools version, wasn't sure if it would be done there. Can that be done in a follow up PR?

@Birdrock
Copy link
Contributor

Birdrock commented Jun 9, 2021

@varshaprasad96 I can update my PR (#2200) to keep up to date with versions, if that helps.

@varshaprasad96
Copy link
Member Author

@Birdrock sure, anything works. If you would like to have 2 separate PRs, then we can have k8s 1.21 bump separately. Since #2200 is approved, we can merge that first. i'll rebase this one.

camilamacedo86
camilamacedo86 reviewed Jun 10, 2021
View reviewed changes
go.mod Show resolved Hide resolved
@estroz
Copy link
Contributor

estroz commented Jun 10, 2021

@varshaprasad96 I'd rather all k8s deps be updated in the same PR.

@varshaprasad96
Copy link
Member Author

yep, I'll bump the dependencies in plugin here.

@estroz estroz mentioned this pull request Jun 10, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@varshaprasad96
Copy link
Member Author

/hold
this is blocked by kubernetes-sigs/kubebuilder-declarative-pattern#160

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2021
@varshaprasad96 varshaprasad96 mentioned this pull request Jun 29, 2021
Closed
@varshaprasad96
✨ bump k8s dependencies to 1.21
3b251ce 
Bump k8s dependencies in kubebuilder binary to 1.21

Signed-off-by: varshaprasad96 <[email protected]>
@varshaprasad96
update testdata
66a0311
@varshaprasad96
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2021
@varshaprasad96
Copy link
Member Author

@estroz @camilamacedo86 - the PR is ready for review

estroz
estroz reviewed Jun 30, 2021
View reviewed changes
test/testdata/generate.sh Outdated Show resolved Hide resolved
@estroz
Copy link
Contributor

estroz commented Jul 1, 2021

/retest

@estroz
Copy link
Contributor

estroz commented Jul 1, 2021

/override APIDiff
/approve
/lgtm

I'll likely have to force merge this since I don't think overrides will work on action runs.

@k8s-ci-robot
Copy link
Contributor

@estroz: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • APIDiff

Only the following contexts were expected:

  • netlify/kubebuilder/deploy-preview
  • pull-kubebuilder-e2e-k8s-1-14-10
  • pull-kubebuilder-e2e-k8s-1-15-12
  • pull-kubebuilder-e2e-k8s-1-16-15
  • pull-kubebuilder-e2e-k8s-1-17-11
  • pull-kubebuilder-e2e-k8s-1-18-8
  • pull-kubebuilder-e2e-k8s-1-19-4
  • pull-kubebuilder-test
  • tide

In response to this:

/override APIDiff
/approve
/lgtm

I'll likely have to force merge this since I don't think overrides will work on action runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@estroz estroz merged commit 1831527 into kubernetes-sigs:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@estroz estroz Awaiting requested review from estroz

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@varshaprasad96 @estroz @Birdrock @k8s-ci-robot @camilamacedo86