Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Spec for Phase 2 Plugins #2281

Merged
merged 1 commit into from
Aug 31, 2021
Merged

✨ Spec for Phase 2 Plugins #2281

merged 1 commit into from
Aug 31, 2021

Conversation

rashmigottipati
Copy link
Contributor

  • a description of the change
    Add a spec for Phase 2 Plugins by defining the contract between kubebuilder and the external plugin based on what data kubebuilder passes to the external plugin and receives from the external plugin.

  • the motivation for the change
    Creating this spec based on the POC work that was done (more details in the EP: 📖 Plugin Phase 2 Enhancement Proposal #2243).

Signed-off-by: Rashmi Gottipati [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @rashmigottipati. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2021
@rashmigottipati rashmigottipati changed the title ✨WIP: Spec for Phase 2 Plugins Spec for Phase 2 Plugins Aug 9, 2021
@rashmigottipati rashmigottipati changed the title Spec for Phase 2 Plugins ✨ Spec for Phase 2 Plugins Aug 9, 2021
@rashmigottipati
Copy link
Contributor Author

rashmigottipati commented Aug 9, 2021 •
edited
Loading

/cc @estroz @jmrodri

@k8s-ci-robot
Copy link
Contributor

@rashmigottipati: GitHub didn't allow me to request PR reviews from the following users: jmrodri.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jmrodri

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jmrodri
jmrodri reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we support binary files

pkg/externalplugin/types.go Outdated Show resolved Hide resolved
pkg/externalplugin/types.go Outdated Show resolved Hide resolved
jmrodri
jmrodri approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jmrodri: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estroz
estroz reviewed Aug 31, 2021
View reviewed changes
pkg/externalplugin/types.go Outdated Show resolved Hide resolved
pkg/externalplugin/types.go Outdated Show resolved Hide resolved
pkg/externalplugin/types.go Outdated Show resolved Hide resolved
@estroz
Copy link
Contributor

estroz commented Aug 31, 2021

The package path should be pkg/plugin/external imo.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2021
@rashmigottipati
Spec for Phase 2 Plugins
44df0f6 
Signed-off-by: Rashmi Gottipati <[email protected]>
@rashmigottipati
Copy link
Contributor Author

rashmigottipati commented Aug 31, 2021 •
edited
Loading

@estroz addressed comments and modified the package path to pkg/plugin/external.

estroz
estroz approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, jmrodri, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit b05a6f6 into kubernetes-sigs:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@estroz estroz estroz approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashmigottipati @k8s-ci-robot @estroz @jmrodri