-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Defer GinkgoRecover() in test goroutines #2345
Conversation
Add a `defer GinkgoRecover()` call to the beginning of async functions in test code so that assertion failures will be shown to the user on failure. Signed-off-by: Adam Snyder <[email protected]>
Hi @armsnyder. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: armsnyder, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@estroz Thanks for approving! It looks like the workflow got rate limited when querying goveralls? |
Add a
defer GinkgoRecover()
call to the beginning of async functions in test code so that assertion failures will be shown to the user on failure.Fixes #2328
Signed-off-by: Adam Snyder [email protected]