Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix e2e tests that timeout when run locally #2356

Merged
merged 1 commit into from
Oct 1, 2021
Merged

🐛 Fix e2e tests that timeout when run locally #2356

merged 1 commit into from
Oct 1, 2021

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Sep 29, 2021 •
edited
Loading

Increases the go test timeout value by 10 mins so that e2e tests can run locally.

At present, they are timing out which makes it impossible to run them successfully.

Fixes #2355

Note: Also, updated the default Kubernetes version to the latest patch release of 1.18.

@hickeyma
Increase timeout for e2e tests
c65e6c5 
e2e tests run locally keep timing out. This change
is to increase the timeout so they can finish.

Signed-off-by: Martin Hickey <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2021
@hickeyma hickeyma mentioned this pull request Sep 29, 2021
Closed
camilamacedo86
camilamacedo86 approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, hickeyma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 87eb9d5 into kubernetes-sigs:master Oct 1, 2021
@hickeyma hickeyma deleted the fix/e2e-test-timeout branch October 4, 2021 07:26
@hickeyma
Copy link
Contributor Author

hickeyma commented Oct 4, 2021

Thanks @camilamacedo86 for review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@estroz estroz Awaiting requested review from estroz

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e test run locally timing out
3 participants
@hickeyma @k8s-ci-robot @camilamacedo86