Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Upgrade e2e test for latest Kubernetes versions #2371

Merged
merged 2 commits into from
Oct 11, 2021
Merged

🌱 Upgrade e2e test for latest Kubernetes versions #2371

merged 2 commits into from
Oct 11, 2021

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Oct 4, 2021

Upgrade the e2e tests for Kubernetes 1.20, 1.21 and 1.22

Closes #2306

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2021
@hickeyma hickeyma mentioned this pull request Oct 5, 2021
Closed
estroz
estroz reviewed Oct 5, 2021
View reviewed changes
test/e2e/local.sh Outdated Show resolved Hide resolved
@hickeyma hickeyma requested a review from estroz October 6, 2021 17:15
@hickeyma hickeyma mentioned this pull request Oct 7, 2021
Merged
@hickeyma hickeyma force-pushed the feat/upg-e2e-tst-k8s-sup branch 2 times, most recently from b3d95a7 to 51f887d Compare October 7, 2021 09:39
@hickeyma
Copy link
Contributor Author

hickeyma commented Oct 7, 2021

Thanks for the reviews and feedback @camilamacedo86 @estroz. Updated and ready for review again.

@hickeyma
Copy link
Contributor Author

hickeyma commented Oct 7, 2021

Pushed prow kubernetes/test-infra#23935 as I inadvertently set the k8s versions to the latest versions rather than the lates Kind k8s versions supported. This should fix the CI issues.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2021
@hickeyma
Copy link
Contributor Author

hickeyma commented Oct 7, 2021

/retest

1 similar comment
@estroz
Copy link
Contributor

estroz commented Oct 7, 2021

/retest

@estroz
Copy link
Contributor

estroz commented Oct 7, 2021

This can't be merged until kubernetes/test-infra#23950 merges. We need to test older versions. @hickeyma please make sure someone from the kubebuilder config OWNERS file has signed off on infra PR's in the future. Not a big deal in the end, stuff happens!

@estroz
Copy link
Contributor

estroz commented Oct 8, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 8, 2021 •
edited
Loading

@hickeyma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-21-5 222bf2a link false /test pull-kubebuilder-e2e-k8s-1-21-5
pull-kubebuilder-e2e-k8s-1-22-2 222bf2a link false /test pull-kubebuilder-e2e-k8s-1-22-2
pull-kubebuilder-e2e-k8s-1-20-11 222bf2a link false /test pull-kubebuilder-e2e-k8s-1-20-11

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hickeyma
Copy link
Contributor Author

hickeyma commented Oct 8, 2021

This can't be merged until kubernetes/test-infra#23950 merges. We need to test older versions. @hickeyma please make sure someone from the kubebuilder config OWNERS file has signed off on infra PR's in the future. Not a big deal in the end, stuff happens!

Sorry my bad. It just happened to be merged very quickly.

@camilamacedo86
Copy link
Member

/retest-required

@hickeyma
Update the Kind version
7e7b938 
kind v0.11.0+ supports Kubernetes 1.20+

Signed-off-by: Martin Hickey <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2021
@hickeyma
Copy link
Contributor Author

There were build issues with prow for Kubernetes v1.20+. This is because Kind v0.7.0 does not support Kubernetes v1.20+. Thanks to @BenTheElder for the "heads up" on slack. This did not show when testing locally as had v0.11.1 already installed.

Pushed change to common script to install v0.11.1. CI now running as expected with all Kubernetes versions.

@hickeyma
Copy link
Contributor Author

@camilamacedo86 @estroz This is good to review again when you get a chance.

@hickeyma hickeyma requested a review from estroz October 11, 2021 10:32
@estroz
Copy link
Contributor

estroz commented Oct 11, 2021

@hickeyma thanks again!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz, hickeyma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 827b3ef into kubernetes-sigs:master Oct 11, 2021
@hickeyma hickeyma deleted the feat/upg-e2e-tst-k8s-sup branch October 12, 2021 10:17
@hickeyma
Copy link
Contributor Author

Thanks @camilamacedo86 and @estroz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@estroz estroz Awaiting requested review from estroz

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that the tests runs against the latest k8s version
4 participants
@hickeyma @estroz @k8s-ci-robot @camilamacedo86