Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ upgrade golang version to 1.18 #2561

Closed
wants to merge 1 commit into from

Conversation

AlmogBaku
Copy link
Member

@AlmogBaku AlmogBaku commented Mar 25, 2022

Description:
This PR introduces Golang 1.18 support for Kubebuilder.
It makes Kubebuilder use go1.18 for both compiling the CLI and the scaffolded code.

For more information about this, see issue #2559

Motivation:
Closes #2559

@k8s-ci-robot
Copy link
Contributor

Welcome @AlmogBaku!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @AlmogBaku. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlmogBaku
To complete the pull request process, please assign pwittrock after the PR has been reviewed.
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlmogBaku
Copy link
Member Author

/cc @AvineshTripathi

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2022
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2022
AlmogBaku added a commit to AlmogBaku/test-infra that referenced this pull request Mar 26, 2022
---
Kubebuilder's master branch is introducing support for Golang 1.18
kubernetes-sigs/kubebuilder#2561
@AlmogBaku
Copy link
Member Author

This PR to the test-infra should upgrade prow to use golang 1.18 for our tests:
kubernetes/test-infra#25775

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits for we are able to get this one merged

a) Could you please update the PR title for :sparkles: upgrade Go version to 1.18 (adds supports to go 1.18) - Done
b) ensure that all plugins use golang 1.18 ( we are not updating go/v2 see (#2571
c) Could you revert the min go version forced by the CLI and ensure the same values for go/v2?
d) By the latest could we update the quick start after deep thought, I think we do not need to have the go version for each release and we should keep the info regards the latest one only, so go version >= 1.18 wdyt? Then we close with this PR this one #2548 too? We do not track in the docs the info/changes for each release made so that makes no sense we have the go version per release.

.github/workflows/apidiff.yml Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
@AlmogBaku AlmogBaku changed the title ⚠️ bump golang version to 1.18 : sparkle: bump golang version to 1.18 Mar 29, 2022
@AlmogBaku AlmogBaku changed the title : sparkle: bump golang version to 1.18 ✨ bump golang version to 1.18 Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2022
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see that we need to do a little bit more here to get this one merged
Could you please try to address the commands/suggestions?

IF you have doubts feel free to ping me in the slack.

Makefile Outdated Show resolved Hide resolved
@AlmogBaku AlmogBaku force-pushed the master branch 3 times, most recently from d9580f6 to e6a7b29 Compare April 7, 2022 15:51
@AlmogBaku
Copy link
Member Author

Hey all,
I'm trying to understand where this PR stand, and why it's blocked:

Please comment here on your notes, and let's take a call what are the next action items.
@joelanford @camilamacedo86

@AlmogBaku AlmogBaku force-pushed the master branch 2 times, most recently from 3a5358b to b43e2ea Compare April 13, 2022 17:02
@AlmogBaku
Copy link
Member Author

Hi all,
Is there anything left before merging this?
@camilamacedo86 @joelanford @AvineshTripathi

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 21, 2022

@AlmogBaku: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-test e560137 link true /test pull-kubebuilder-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlmogBaku,

The issue was updated to clarify all that was discussed and what we will need to do to achieve this goal. See: #2561

Thank you for working on that and helping us to identify the needs.

AlmogBaku added a commit to AlmogBaku/controller-tools that referenced this pull request Apr 21, 2022
Go changed the results of the `ReadBuildInfo` in go 1.18. Now it always returns information also for modules

For more information on the use-case see
kubernetes-sigs/kubebuilder#2561 (comment)
@AlmogBaku AlmogBaku changed the title ✨ bump golang version to 1.18 ✨ upgrade golang version to 1.18 Apr 21, 2022
@camilamacedo86 camilamacedo86 dismissed their stale review April 21, 2022 14:10

I think we will need to discuss few points but I will not block the pr

@camilamacedo86
Copy link
Member

camilamacedo86 commented Apr 22, 2022

@AlmogBaku,

Again, thank you for your terrific work 🥇 and help us identify what we will need to do to accomplish this goal.
However, we checked that we will need to:

a) split the changes between CLI and go/v3 ( scaffold )
b) also we will need to move forward with other updates and changes along with

In this way, wdyt about we close this one and then work on the new PRs?

/hold

@camilamacedo86 camilamacedo86 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022
@k8s-ci-robot
Copy link
Contributor

@AlmogBaku: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2022
swatisehgal added a commit to swatisehgal/numaresources-operator that referenced this pull request May 19, 2022
As of today, Kube-builder does not support go 1.18:
kubernetes-sigs/kubebuilder#2561.

Also, note that installing executables with go get is deprecated
in go1.18 (xref:https://go.dev/doc/go-get-install-deprecation).

Co-authored-by: Francesco Romani <[email protected]>
Signed-off-by: Swati Sehgal <[email protected]>
liurupeng pushed a commit to liurupeng/test-infra that referenced this pull request Jun 7, 2022
---
Kubebuilder's master branch is introducing support for Golang 1.18
kubernetes-sigs/kubebuilder#2561
kaalams pushed a commit to kaalams/test-infra that referenced this pull request Jul 14, 2022
---
Kubebuilder's master branch is introducing support for Golang 1.18
kubernetes-sigs/kubebuilder#2561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support go 1.18
6 participants