Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update kustomize version for Macbook M1 support #2565

Conversation

hajowieland
Copy link
Contributor

Currently we set KustomizeVersion to 3.8.7 where there are no kustomize arm64 assets available for Macbook M1 machines.

Starting with kustomize 4.2.0 there are darwin_arm64 packages available. We should update the kustomize version so developers with M1 machines can download the kustomize binary with install_kustomize.sh in Makefile.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @hajowieland. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hajowieland
To complete the pull request process, please assign camilamacedo86 after the PR has been reviewed.
You can assign the PR to them by writing /assign @camilamacedo86 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

camilamacedo86 commented Mar 27, 2022

Hi @hajowieland,

Thank you for raising it.

We did not make this updated because of: #2498 (comment). Also, see: #2498 (comment)

I raise an issue for we check how we will solve it : #2566

@camilamacedo86
Copy link
Member

HI @hajowieland,

This PR would not pass because would be required to re-gen all samples ( see the contribution guide, before pushing a pr you need to run make generate )

However, we need to discuss if we should bump the kustomize in v3 and risk or try to ensure in another way that we do not introduce a breaking change within the Golang v3 plugin or if it should only be shipped on the Go v4 and we just support this arch there. Please, follow up on the issue: #2566

Let's try to centralize there the convey of our discussions and etc.
So, that I hope that you do not mind we close this PR
However, please feel free to re-open it if you see that fits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants