Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(config-gen) Updated the image gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.11.0 #2595

Merged
merged 1 commit into from
Apr 4, 2022
Merged

✨(config-gen) Updated the image gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.11.0 #2595

merged 1 commit into from
Apr 4, 2022

Conversation

NikhilSharmaWe
Copy link
Member

Fixes #2592

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2022
@NikhilSharmaWe NikhilSharmaWe force-pushed the rbacProxyImageVer branch 2 times, most recently from 448d95a to 684baec Compare April 3, 2022 17:27
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2022
camilamacedo86
camilamacedo86 reviewed Apr 4, 2022
View reviewed changes
pkg/cli/alpha/config-gen/testdata/enablecertmanager/expected.yaml Outdated
@@ -353,7 +353,7 @@ webhooks:
---
# The following manifests contain a self-signed issuer CR and a certificate CR.
# More document can be found at https://docs.cert-manager.io
# WARNING: Targets CertManager 0.11 check https://docs.cert-manager.io/en/latest/tasks/upgrading/index.html for
# WARNING: Targets CertManager 0.11 check https://docs.cert-manager.io/en/latest/tasks/upgrading/index.html for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the space here broke the tests.
See that it is a mock test result so that we can compare what is the result with it (what is expected)
You can check that by looking in the logs: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder/2595/pull-kubebuilder-test/1510670366261907456#1:build-log.txt%3A77-84

c/c @NikhilSharmaWe

Revert this one for we are able to move forward.

Copy link
Member Author

@NikhilSharmaWe NikhilSharmaWe Apr 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that in the logs but did not realize that it was important for them to be exactly same, I thought the error was because of something else.
Thanks for pointing out and explaining.

camilamacedo86
camilamacedo86 requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contributon
But we need to ensure that it pass in the CI
See: https://github.com/kubernetes-sigs/kubebuilder/pull/2595/files#r841483786

camilamacedo86
camilamacedo86 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

Great work 🥇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2022
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit bb9cbb5 into kubernetes-sigs:master Apr 4, 2022
@ryantking ryantking mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(config-gen) Update the image gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.11.0
3 participants
@NikhilSharmaWe @k8s-ci-robot @camilamacedo86