🐛 For go/v3 plugin: Avoid to add duplicated code fragments

[mrkm4ntr]

Every time we create webhook for existing project, the following duplicated code are injected.

err = admissionv1beta1.AddToScheme(scheme)
Expect(err).NotTo(HaveOccurred())

[k8s-ci-robot]

Hi @mrkm4ntr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

Thank you for your contribution 🥇

Following some questions:
a) Is your goal here to begin to use "k8s.io/api/admission/v1" instead of "k8s.io/api/admission/v1beta1"?

b) Why it is a bug? Could you please clarifies? what are the problems faced because of this? Could please raise an issue for that? Then, we can properly check it. WDYT?

Additionally, see that: when we change any scaffold we need to use the command make generate to update the samples under the testdata dir.

[mrkm4ntr]

a) Is your goal here to begin to use "k8s.io/api/admission/v1" instead of "k8s.io/api/admission/v1beta1"?

Sorry, my main goal is deduplicate following code. This is added again and again per every kubebuilder create webhook.

err = admissionv1beta1.AddToScheme(scheme)
Expect(err).NotTo(HaveOccurred())

I will change the PR title and commit message.

I also addressed this TODO message, but I will split this PR from this.

// TODO: admission webhook versions should be based on the input of the user. For More Info #1664

[mrkm4ntr]

Additionally, see that: when we change any scaffold we need to use the command make generate to update the samples under the testdata dir.

Of course, I already executed make generate.

[mrkm4ntr]

@camilamacedo86 Thank you for your comments. I changed the goal of this PR. PTAL.

[camilamacedo86]

Thank you for the contribution and for work on the review of this PR 🥇
It makes sense for me 👍

/approved
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mrkm4ntr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

/hold cancel

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-18-8

[camilamacedo86]

/lgtm