-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump Kubernetes version (1.24.1 -> 1.25.0) #2907
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oscr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks good. I think you have to add a bit more text to the PR description to make the PR verifier happy. /lgtm /assign @camilamacedo86 |
@@ -44,7 +44,7 @@ builds: | |||
- darwin_amd64 | |||
- darwin_arm64 | |||
env: | |||
- KUBERNETES_VERSION=1.24.1 | |||
- KUBERNETES_VERSION=1.25.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Thank you for the contribution 🥇
We need to update the whole project accordingly and not only the goreleaser file.
See: #2908
Would you like to start to help out by creating the envtools binaries for 1.25?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c/c @sbueringer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Thank sounds great @camilamacedo86.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 Thx, I overlooked the base branch of this PR.
Just out of curiosity. Does bumping the version on the tools-releases branch depend on kubebuilder itself on main being bumped before?
EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sbueringer,
EDIT: Ah "Would you like to start to help out by creating the envtools binaries for 1.25?" that's actually bumping the tools-release branch, right? And it has to be done first
We use the envtest in the scaffolds as well see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/Makefile#L5
But updating the goreleases would need to be done when we update the whole project.
/lgtm cancel |
Hi @oscr, To do the bump that means updating all project, scaffolds and dependencies. |
Bump Kubernetes version (1.24.1 -> 1.25.0) as part of kubernetes-sigs/cluster-api#6661
cc @sbueringer