-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Build kubebuilder-tools for k8s 1.28.0 #3545
✨ Build kubebuilder-tools for k8s 1.28.0 #3545
Conversation
Signed-off-by: Stefan Büringer [email protected]
/assign @camilamacedo86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold |
@killianmuldoon hold for? (you don't have approver rights in this repo anyway :)) |
No need to hold - just didn't know what the approval flow is in this repo - and auto-wrote |
/cc @varshaprasad96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sbueringer @furkatgofurov7 is there a tight timeline you are looking at to get envtest binaries for 1.28? The build is usually triggered along with a KB release. Now that we have c-r and controller-tools updated, we should be able to get this in soon. |
/hold cancel (just undoing my previous hold) |
From my side there is no rush. |
Same, just wanted to see if we can get more eyes on this, thanks for info @varshaprasad96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/aproved
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/hold cancel Yes, we can move forward within. |
Signed-off-by: Stefan Büringer [email protected]