✨ add golangci integration to the default scaffold #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
add-lint
branch
2 times, most recently
from
959a457
to
438443e
Compare
|
/test pull-kubebuilder-e2e-k8s-1-26-0 |
camilamacedo86
force-pushed
the
add-lint
branch
from
438443e
to
78226ae
Compare
|
/test pull-kubebuilder-e2e-k8s-1-27-1 |
camilamacedo86
force-pushed
the
add-lint
branch
from
78226ae
to
2016037
Compare
|
/hold Let's discuss if we should add in the default scaffold or create a new plugin |
k8s-ci-robot
added
the
do-not-merge/hold
camilamacedo86
force-pushed
the
add-lint
branch
from
2016037
to
46ea676
Compare
|
/hold cancel good to fly |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-kubebuilder-e2e-k8s-1-26-0 |
varshaprasad96
approved these changes
Sep 11, 2023
| golangci-lint: | ||
| @[ -f $(GOLANGCI_LINT) ] || { \ | ||
| set -e ;\ | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell dirname $(GOLANGCI_LINT)) v1.54.2 ;\ |
There was a problem hiding this comment.
Can we make the version global variable? So that it can be changed anytime if needed.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add golangci integration to the default scaffold
Closes: #3216
Closes: #3119