📖 Update docs for using Decoder with Core Type Webhook #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Signed-off-by: Joe Searcy <[email protected]>
camilamacedo86
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
It shows great for me 🥇
Thank you for raising it.
I will share with controller-runtime maintainers.
It would be great get their review on this one
Hi @vincepri @FillZpp @alvaroaleman @erikgb,
Could you please check if that is the best approach recommended by you?
If so, can you please LGTM this one?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, phenixblue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Looks good /lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation around adding a
Decoderto yourAdmission.Handle()method for a webhook that deals with Core Types.The existing documentation references creating an
InjectDecodermethod, which is no longer supported in newer versions ofcontroller-runtime. These updates to the docs follow the latest method specified in thecontroller-runtimelibrary.fixes #3604