-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add e2e tests scaffolded in default layout #3670
Conversation
Hi @Lauquik. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/plugins/golang/v4/scaffolds/internal/templates/test/utils/utils.go
Outdated
Show resolved
Hide resolved
testdata/project-v4-multigroup-with-deploy-image/api/crew/v1/webhook_suite_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, but I think we still require some adjusts
- Rebase with master
- Do not change the current e2e tests to try run the sample tests. The e2e tests executed run the e2e tests scaffolds for kubebuilder itself. We need a new GitHub action that will run the sample tests and be configured with kind
- Ensure that the final scaffold has only what is required for end users.
/ok-to-test |
bf5b3d1
to
1359d10
Compare
@camilamacedo86 i have created a whole new workflow for sample project-v4 and removed the sample-e2e.sh script, is it okay? or require any changes, i'm open to receiving any suggestion and guidance |
Hi @Lauquik,
That said, to ensure the integrity of our new e2e tests, we need a dedicated GitHub Action. While it's not necessary to test every single sample (and if doing so simplifies the process, that's acceptable), a streamlined approach might be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Lauquik
Very terrific great work 🥇
I think we have just a couple of nits to sort out, and then it is good to fly.
@camilamacedo86 i think you are right removing the test dir is not the best approach, i will think of some other solution |
Signed-off-by: Lauquik <[email protected]>
@camilamacedo86 I have modified the scaffolded Makefile to exclude the e2e test when running 'make test,' so there's no need to remove the test directories explicitly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🥇
It is great for me so I am approving this one
/approved
Let's give some time to see if others also want to do some review.
If nobody came with a second review or objections we can lgtm this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Lauquik 👍🏼 The PR Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It seems good to fly
we can always push improvements and etc in a follow up
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir, Lauquik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
adding testing scaffold for the default layout of our project
Test perfoms the follwoing tasks
Fixes
#3605