✨ (go/v4) : Ensure versioning of tools and binaries installed via Makefile

[lukas016]

Fixes #3715

PR solves primary issue with synchronization of tools version between developers where older copies of repo can use older versions of binaries and it isn't updated by makefile.

PR unified way how tools are installed and adding better support for versioning of binary based on binary names.
It add new function into makefile and modified installation targets for tools.
It contains more specific version of tool setup-envtest, which was set to release-0.16 branch because this tools doesn't support proper versioning. It isn't ideally solution but still better as latest.

output:

ls bin 
controller-gen-v0.13.0     golangci-lint-v1.54.2      kustomize-v5.2.1           setup-envtest-release-0.16

make generate manifests undeploy test lint
.../example/bin/controller-gen-v0.13.0 object:headerFile="hack/boilerplate.go.txt" paths="./..."
.../example/bin/controller-gen-v0.13.0 rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
.../example/bin/kustomize-v5.2.1 build config/default | kubectl delete --ignore-not-found=false -f -
...
KUBEBUILDER_ASSETS=".../example/bin/k8s/1.28.3-darwin-arm64" go test $(go list ./... | grep -v /e2e) -coverprofile cover.out
...
.../example/bin/golangci-lint-v1.54.2 run

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: lukas016 / name: Lukas Koszegy (cce61e1)

[k8s-ci-robot]

Welcome @lukas016!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @lukas016. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mateusoliveira43]

LGTM ✅

[lukas016]

/assign @camilamacedo86

[camilamacedo86]

Thank you for your contribution 🥇

Could you please:
a) Run make generate then the changes made will result in the samples under testdata and docs
b) Squash the commits. we can only merge when we have 1 commit in the PR

/ok-to-test

[camilamacedo86]

Hi @varshaprasad96

Could you please give a help here?
Are you OK with this one as well?
WDYT

[varshaprasad96]

Thanks for the contribution! The changes look good to me. One thing to add is that the underlying KB binaries which are installed by setup-envtest would still remain until they are cleaned up. This is something we need not handle here, but just mentioning because a full cleanup would still not occur as mentioned in the issue.
Thinking about it, an alternative to handle it is to do a setup-envtest cleanup if we identify a mismatched version from use command. But we can handle that in follow up.

@lukas016 we still need to run make generate to update the testdata.

[lukas016]

Thanks for the contribution! The changes look good to me. One thing to add is that the underlying KB binaries which are installed by setup-envtest would still remain until they are cleaned up. This is something we need not handle here, but just mentioning because a full cleanup would still not occur as mentioned in the issue. Thinking about it, an alternative to handle it is to do a setup-envtest cleanup if we identify a mismatched version from use command. But we can handle that in follow up.

@lukas016 we still need to run make generate to update the testdata.

I will implement suggestions today and i will call make generate too.

[lukas016]

i fixed all conversions, called make generate and squashed commits.

[camilamacedo86]

Could you please rebase with master?

It has changes that are merged already.

Thank you

[camilamacedo86]

I did not test manually but for me shows fine

/lgtm

[camilamacedo86]

@varshaprasad96 @everettraven It seems to make a lot of sense for Kubebuilder since we do not support any other language. However, I just want to come to your attention because when the bump of a new release is done in Operator SDK for Helm/Ansible plugins, it will be required. Just take this line and replace it to use the script instead since going installed locally is not a pre-requisite.

[camilamacedo86]

Based in the comment #3718 (review) either

it seems ready to go, so I am approving this one.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lukas016, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

@mateusoliveira43 @varshaprasad96

This part we will need to came back to use latest
we cannot relay on the branch.
We need to relay on the tag

Downloading sigs.k8s.io/controller-runtime/tools/[email protected]
go: sigs.k8s.io/controller-runtime/tools/[email protected]: sigs.k8s.io/controller-runtime/tools/[email protected]: invalid version: unknown revision release-0.17

[mateusoliveira43]

yeah, checked and the last release is 0.17, but there is no branch to it. Probably need some change in controller-runtime to allow use of non-latest with setup-envtest