-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Specify what is run and deployed #3788
📖 Specify what is run and deployed #3788
Conversation
letthefireflieslive
commented
Feb 19, 2024
- Add brief explanation for newbies to understand
- So that new reader that will have a smoother understanding
- Clarifies what is being run and why it's not deployed the first time
Welcome @letthefireflieslive! |
Hi @letthefireflieslive. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🥇
Could you please address the comments in the review so that we can get your suggestions merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits so that we can get this one merged
Thank you for your collaboration 🥇
Briefly explain what is run and why it's `make run` at first and explain why the controller is deployed in the latter Update docs/book/src/quick-start.md Co-authored-by: Camila Macedo <[email protected]>
3767f3d
to
17108bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approved
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, letthefireflieslive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |