🐛 fix: remove trailing whitespace in readme gen #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bzub
changed the title
There was a problem hiding this comment.
I think you need to run make generate for tests to pass
There was a problem hiding this comment.
I'm getting a compile error when I run make generate. I'll look for a container I can run it in.
There was a problem hiding this comment.
Fixed my issue by using go 1.21 rather than 1.22. Pushed changes after make generate.
This should help users start out with a README that avoids trailing whitespaces.
bzub
force-pushed
the
3812-trailing_whitespace
branch
from
cefebb7
to
99c3ef2
Compare
k8s-ci-robot
added
size/M
mateusoliveira43
approved these changes
Mar 8, 2024
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bzub, camilamacedo86, mateusoliveira43 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help users start out with a README that avoids trailing
whitespaces.
Fixes: #3812