Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 : fix traling spaces in the docs and add check as automate fix to the make generate #3826

Merged
merged 2 commits into from
Mar 29, 2024
Merged

🌱 : fix traling spaces in the docs and add check as automate fix to the make generate #3826

merged 2 commits into from
Mar 29, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Mar 29, 2024 •
edited
Loading

Just fix and check in the CI for trailing spaces

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 29, 2024
@camilamacedo86 camilamacedo86 changed the title 🌱 fix triling spaces in the docs and add check as automate f… 🌱 : fix triling spaces in the docs and add check as automate fix to the make generate Mar 29, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-traillingspaces branch 4 times, most recently from 911347f to 3df5ed5 Compare March 29, 2024 20:00
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 29, 2024
@camilamacedo86 camilamacedo86 changed the title 🌱 : fix triling spaces in the docs and add check as automate fix to the make generate WIP : 🌱 : fix triling spaces in the docs and add check as automate fix to the make generate Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2024
@camilamacedo86 camilamacedo86 changed the title WIP : 🌱 : fix triling spaces in the docs and add check as automate fix to the make generate 🌱 : fix traling spaces in the docs and add check as automate fix to the make generate Mar 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2024
@camilamacedo86
Copy link
Member Author

@bzub @mateusoliveira43

See now we can solve it across the whole project when we run make generate
Also, now we are checking of the spaces so we will not get merged stuff with trailing spaces.

@camilamacedo86 camilamacedo86 mentioned this pull request Mar 29, 2024
Closed
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Mar 29, 2024
Kavinjsir
Kavinjsir approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

Hi @Kavinjsir

Can you please either create a comment /lgtm so that we can get this one merged ?
thank you ❤️

@Kavinjsir
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 568d81e into kubernetes-sigs:master Mar 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@Kavinjsir Kavinjsir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @k8s-ci-robot @Kavinjsir