-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ : (go/v4): Replace deadline
in favor of timeout
in golangci-lint
configuration
#3865
✨ : (go/v4): Replace deadline
in favor of timeout
in golangci-lint
configuration
#3865
Conversation
…tion As of 1.57 version, golangci-lint deprecated the `deadline` linter setting (https://github.com/golangci/golangci-lint/releases/tag/v1.57.0). This PR changes `deadline` to `timeout` in the `.golangci.yml` configuration both for the project setup and for the `.golangci.yml` scaffolding.
Hi @afritzler. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
deadline
in favor of timeout
in golangci-lint
configurationdeadline
in favor of timeout
in golangci-lint
configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approved
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afritzler, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As of 1.57 version, golangci-lint deprecated the
deadline
linter setting(https://github.com/golangci/golangci-lint/releases/tag/v1.57.0). This PR changes
deadline
totimeout
in the.golangci.yml
configuration both for the project setup and for the.golangci.yml
scaffolding.