-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix generate command not respecting --namespaced=false of APIs #3970
🐛 fix generate command not respecting --namespaced=false of APIs #3970
Conversation
Hi @antonincms. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
166d9ed
to
6a18252
Compare
Change the getAPIResourceFlags function to return `--namespaced=false` if resource.API.Namespaced and add corresponding test. This is needed since currently `kubebuilder alpha migrate` always create namespaced APIs due to the default of namespaced being true.
6a18252
to
09bf649
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antonincms, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change the getAPIResourceFlags function to return
--namespaced=false
if resource.API.Namespaced and add corresponding test.This is needed since currently
kubebuilder alpha migrate
always create namespaced APIs due to the default of namespaced being true.Fixes #3969