Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 (cleanup and enhance) improve and make clear info about setup envtest and its binaries and that old location is deprecated #4083

Merged
merged 1 commit into from
Aug 17, 2024
Merged

📖 (cleanup and enhance) improve and make clear info about setup envtest and its binaries and that old location is deprecated #4083

merged 1 commit into from
Aug 17, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Aug 17, 2024 •
edited
Loading

This PR only update the Artifact docs in order to:

More info: #4082

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2024
@camilamacedo86 camilamacedo86 changed the title 📖 improve and make clear info about setup envtest and its binaries 📖 (cleanup and enhance) improve and make clear info about setup envtest and its binaries as deprecations Aug 17, 2024
@camilamacedo86 camilamacedo86 changed the title 📖 (cleanup and enhance) improve and make clear info about setup envtest and its binaries as deprecations 📖 (cleanup and enhance) improve and make clear info about setup envtest and its binaries and that old location is deprecated Aug 17, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2024
@camilamacedo86
Copy link
Member Author

it is too small and we need it for the release
Therefore, make no sense wait for reviews.
We can always change it if required afterwords.

Cheers,

@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker labels Aug 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit dd5b8bc into kubernetes-sigs:master Aug 17, 2024
18 checks passed
@camilamacedo86 camilamacedo86 deleted the improve-doc-art branch August 17, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camilamacedo86 @k8s-ci-robot