Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enhances the webhook test template. #4151

Merged

Commits on Sep 9, 2024

  1. 🐛 fix: Enhance the webhook test template

    The webhook scaffold had some oddly indented regions, resulting in the
    generated source code having a mix of tabs and spaces, and was generally
    looking quite ugly.
    
    The gomega asserions are too chatty; errors, and return values are
    checked after first being assigned as variables in scope. This is not
    needed, and Gomega checks all of this for us:
    
    Expect(someFunc()).Error().To(HaveOccurred()) checks both the error, but also that the other return values are zero or nil.
    Expect(someFunc()).To(ContainSubstring("X")) checks both the return value and verifies that the error is nil.
    
    - Indentation
    - simplify gomega assertions
    mogsie committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5d564d2 View commit details
    Browse the repository at this point in the history