Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flesh out documentation on homepage #51

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Flesh out documentation on homepage #51

merged 1 commit into from
Apr 4, 2018

Conversation

pwittrock
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2018
@pwittrock pwittrock force-pushed the docs branch 2 times, most recently from 6789df2 to c0143b6 Compare April 4, 2018 04:11
Liujingfang1
Liujingfang1 reviewed Apr 4, 2018
View reviewed changes
Copy link
Contributor

@Liujingfang1 Liujingfang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me. It includes a lot of info and worth reading. I have a feeling that putting all this info on the homepage might be a little much. We could separate it an put into different files.

README.md Outdated

These files are used to update vendored go dependencies.

## Common controller operations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Common controller operations available? Since following paragraphs explained the controller operations and the corresponding library function.

@pwittrock pwittrock merged commit 12f1fba into kubernetes-sigs:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Liujingfang1 left review comments

@fanzhangio fanzhangio Awaiting requested review from fanzhangio

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwittrock @Liujingfang1 @k8s-ci-robot