Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Set status.observedGeneration for federated resources #1107

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Set status.observedGeneration for federated resources #1107

merged 3 commits into from
Aug 27, 2019

Conversation

marun
Copy link
Contributor

@marun marun commented Aug 15, 2019

Set status.observedGeneration for federated resources to provide an indication of whether the sync controller has processed the current state of resource.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2019
@marun marun requested review from font and xunpan August 15, 2019 14:52
@marun marun added this to the v0.1.0 milestone Aug 16, 2019
@marun marun changed the title WIP Set status.observedGeneration for federated resources Set status.observedGeneration for federated resources Aug 17, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2019
@marun
Copy link
Contributor Author

marun commented Aug 17, 2019

Rebased and ready for review

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 17, 2019
@marun
Copy link
Contributor Author

marun commented Aug 19, 2019

Rebased

test/common/crudtester.go Outdated Show resolved Hide resolved
pkg/controller/sync/status/status.go Outdated Show resolved Hide resolved
This change is in support of adding observedGeneration to status. This
will mean that more than propagation status is stored in th status of
federated resources.
Set status.observedGeneration for federated resources to provide an
indication of whether the sync controller has processed the current
state of a resource.
@marun
Copy link
Contributor Author

marun commented Aug 26, 2019

Rebased and updated to address comments.

Copy link
Contributor

@font font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/kubefedctl/enable/validation.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit e6581d2 into kubernetes-retired:master Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants