Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Fix service status not working issue #1248

Conversation

RainbowMango
Copy link
Contributor

What this PR does / why we need it:
Fixed #1247
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1247

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2020
@RainbowMango
Copy link
Contributor Author

@jimmidyson
Copy link
Contributor

@RainbowMango thank you for this. I'm assuming we're missing test coverage here otherwise this would have been picked up before - would you be able to add some tests for this please?

@RainbowMango
Copy link
Contributor Author

would you be able to add some tests for this please?

@jimmidyson thanks for your quick response :). I guess you mean the tests are E2E tests. Sure, I'd love to.

I was wondering if we can take this PR focus on bug fix and move faster? Actually, not only the tests but the related docs should also be added too, for this I opened an issue to follow these kinds of tasks.

@jimmidyson
Copy link
Contributor

@RainbowMango I'm happy with that - thanks!

@jimmidyson
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 55b7a5f into kubernetes-retired:master Jul 14, 2020
@hectorj2f
Copy link
Contributor

I believe we should do a release this week to get this and other fixes

@RainbowMango
Copy link
Contributor Author

Thank you for your understanding, @jimmidyson . I really like iterating.

I believe we should do a release this week to get this and other fixes

Sounds great. the new release is 0.5.0 or 0.4.1 ?

@RainbowMango RainbowMango deleted the pr_fix_service_status_not_working branch July 14, 2020 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

statusCollection not working for FederatedTypeConfig
4 participants