-
Notifications
You must be signed in to change notification settings - Fork 531
Fix service status not working issue #1248
Fix service status not working issue #1248
Conversation
@RainbowMango thank you for this. I'm assuming we're missing test coverage here otherwise this would have been picked up before - would you be able to add some tests for this please? |
@jimmidyson thanks for your quick response :). I guess you mean the I was wondering if we can take this PR focus on bug fix and move faster? Actually, not only the tests but the related docs should also be added too, for this I opened an issue to follow these kinds of tasks. |
@RainbowMango I'm happy with that - thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I believe we should do a release this week to get this and other fixes |
Thank you for your understanding, @jimmidyson . I really like iterating.
Sounds great. the new release is |
What this PR does / why we need it:
Fixed #1247
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1247
Special notes for your reviewer: