-
Notifications
You must be signed in to change notification settings - Fork 531
charts: split properties for webhook and manager #1261
charts: split properties for webhook and manager #1261
Conversation
@@ -6,19 +6,36 @@ | |||
## | |||
controllermanager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not sure if it works.) Just a guess, would it be better to rename controllermanager
to other common names such as component
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might imply to change the chart name. I don't know if we really want to do that now.
Just a nit, otherwise LGTM. |
charts/kubefed/values.yaml
Outdated
requests: | ||
cpu: 100m | ||
memory: 64Mi | ||
|
||
clusterAvailableDelay: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these properties also applicable only to controller
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are part of controllermanager
main chart, perhaps I can move them up to easily identify the scope for manager
and webhook
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved them up so it is more clear the purpose of the properties manager and webhook. To me, properties such as clusterAvailableDelay
are defining a more generic behavior to the whole kubefed control-plane.
54462c4
to
db6b5e6
Compare
charts/kubefed/charts/controllermanager/templates/deployments.yaml
Outdated
Show resolved
Hide resolved
db6b5e6
to
12b1666
Compare
LGTM. I'd like to give a chance to @irfanurrehman for final approval. |
Thanks for doing this @hectorj2f. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, irfanurrehman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the reviews. |
Note: kubefed brought some other transitive dependency updates with itself. Checked the release notes, haven't seen potentially breaking changes. Note: kubernetes-retired/kubefed#1261 this PR changed the official kubefed chart value handling by putting the common image values under a `controller` and `webhook` fields in the main values file to provide separated control over the two. controllermanager.image -> controllermanager.controller.image -> controllermanager.webhook.image controllermanager.imagePullPolicy-> controllermanager.controller.imagePullPolicy -> controllermanager.webhook.imagePullPolicy controllermanager.replicaCount -> controllermanager.controller.replicaCount -> controllermanager.webhook.replicaCount controllermanager.repository -> controllermanager.controller.repository -> controllermanager.webhook.repository controllermanager.tag -> controllermanager.controller.tag -> controllermanager.webhook.tag
Note: kubefed brought some other transitive dependency updates with itself. Checked the release notes, haven't seen potentially breaking changes. Note: kubernetes-retired/kubefed#1261 this PR changed the official kubefed chart value handling by putting the common image values under a `controller` and `webhook` fields in the main values file to provide separated control over the two. controllermanager.image -> controllermanager.controller.image -> controllermanager.webhook.image controllermanager.imagePullPolicy-> controllermanager.controller.imagePullPolicy -> controllermanager.webhook.imagePullPolicy controllermanager.replicaCount -> controllermanager.controller.replicaCount -> controllermanager.webhook.replicaCount controllermanager.repository -> controllermanager.controller.repository -> controllermanager.webhook.repository controllermanager.tag -> controllermanager.controller.tag -> controllermanager.webhook.tag
What this PR does / why we need it:
We should split the webhook properties from the manager properties.
Also we should expose the env properties for the chart as well.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Closes #1259
Special notes for your reviewer: