-
Notifications
You must be signed in to change notification settings - Fork 531
Transition CRDs from v1beta1 to v1 #1297
Transition CRDs from v1beta1 to v1 #1297
Conversation
05ccce4
to
8b35401
Compare
c38423b
to
b73db7d
Compare
b73db7d
to
87baf01
Compare
04be756
to
450bfca
Compare
2690b24
to
db336df
Compare
@jimmidyson @hectorj2f @xunpan the CI checks are passing now (finally 🎉). Would you mind having a look at this PR, please? |
This commit transitions the CRDs from the kubefed chart and sub-charts as well as all Go code generating CRDs.
db336df
to
2ab409a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, but otherwise LGTM. Wonder if there is a nice way to also upgrade already deployed federated* CRDs to v1 in the same way when upgrading kubefed? Do we even need to worry about that?
Good point @jimmidyson. I will have a look into the upgrade behaviour. Do you know off the top of your head whether there's any upgrade testing in the e2e tests already? |
@makkes I can confirm, there is not any upgrade testing. |
/lgtm |
@jimmidyson: I was finally able to test the upgrade from a former version of kubefed:
No interruption of the federated resources was observed and all new resources are federated properly. |
Thanks @makkes for testing so thoroughly. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Transitions all the CRDs defined in the kubefed chart and sub-charts as well as those generated through
kubefedctl
from apiextensions.k8s.io/v1beta1 to v1.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1296
Special notes for your reviewer: