This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Upgrade tools #1308
Merged
Upgrade tools #1308
+968
−920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @hectorj2f |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, jimmidyson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrades tools (helm, controller-gen, golangci-lint) to latest, as well as go 1.15.3.
By virtue of upgrading
controller-gen, the generated CRDs have converted toapiextensions.k8s.io/v1which is in line with the intention of #1296 (although doesn't fix it because that also requires the default and generated federated type CRDs to beapiextensions.k8s.io/v1.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer: