-
Notifications
You must be signed in to change notification settings - Fork 531
chore: Add labels to service #1310
chore: Add labels to service #1310
Conversation
Welcome @armandgrillet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @armandgrillet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update chart readme then lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: armandgrillet, hectorj2f, jimmidyson, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the possibility to set labels for the controller manager's services. This is useful as new Prometheus versions do not scrape services based on annotations anymore.
Special notes for your reviewer: