-
Notifications
You must be signed in to change notification settings - Fork 531
Remove FederatedIngress feature #1360
Remove FederatedIngress feature #1360
Conversation
1296922
to
16d4fbb
Compare
Thanks @hectorj2f. |
@irfanurrehman Thanks for the review 😍 . I'll address that reference and move forward with the rest of pending tasks. |
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
Signed-off-by: Hector Fernandez <[email protected]>
16d4fbb
to
b8b6fd3
Compare
LGTM for me. Leaving it for another set of eyes to have a check. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lgtm but my experience with this feature is limited so I'll leave the last call to @jimmidyson. |
/lgtm Thanks @hectorj2f for this and for the reviews @irfanurrehman and @makkes! |
What this PR does / why we need it:
This PR removes one of the alpha features FederatedIngress. This feature should not be part of kubefed core as mentioned in #1284. The main intention is to remove from kubefed those features that are not part of its core functionalities, and consequently mark kubefed as beta.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
#1284
Special notes for your reviewer: