Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Remove FederatedIngress feature #1360

Conversation

hectorj2f
Copy link
Contributor

What this PR does / why we need it:

This PR removes one of the alpha features FederatedIngress. This feature should not be part of kubefed core as mentioned in #1284. The main intention is to remove from kubefed those features that are not part of its core functionalities, and consequently mark kubefed as beta.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

#1284
Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 21, 2021
@hectorj2f hectorj2f self-assigned this Feb 21, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2021
@hectorj2f hectorj2f force-pushed the hectorj2f/remove_federatedingress_feat branch from 1296922 to 16d4fbb Compare February 21, 2021 18:30
@irfanurrehman
Copy link
Contributor

Thanks @hectorj2f.
The TOC in userguide still has reference to ingress dns. You might need to update the TOC.
Rest LGTM.

@hectorj2f hectorj2f changed the title [wip] Remove FederatedIngress feature Remove FederatedIngress feature Mar 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2021
@hectorj2f
Copy link
Contributor Author

@irfanurrehman Thanks for the review 😍 . I'll address that reference and move forward with the rest of pending tasks.

@hectorj2f hectorj2f force-pushed the hectorj2f/remove_federatedingress_feat branch from 16d4fbb to b8b6fd3 Compare March 3, 2021 11:32
@irfanurrehman
Copy link
Contributor

LGTM for me. Leaving it for another set of eyes to have a check.
@makkes @jimmidyson

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f, makkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@makkes
Copy link
Contributor

makkes commented Mar 4, 2021

lgtm but my experience with this feature is limited so I'll leave the last call to @jimmidyson.

@jimmidyson
Copy link
Contributor

/lgtm

Thanks @hectorj2f for this and for the reviews @irfanurrehman and @makkes!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5315c4b into kubernetes-retired:master Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants