-
Notifications
You must be signed in to change notification settings - Fork 531
kubefedcluster use cadata in kubeconfig file #1361
kubefedcluster use cadata in kubeconfig file #1361
Conversation
It's an interesting use case. @huiwq1990 I guess you joining cluster with a |
@RainbowMango Yes, kubefedcluster only use kubeconfig's apiserfver endpoint, it should use kubeconfig's cabundle too. |
Looks legit to me. LGTM. @RainbowMango is this change allright with you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be documented somewhere. I would suggest this page is the right place for it.
@makkes @irfanurrehman I write a note specify the change. |
@irfanurrehman Yeah, I think the feature is reasonable. If there is CA data present in KUBECONFIG file, it is the preferred choice. |
/lgtm |
@makkes could you have a look again ? It looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, huiwq1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Kubefedcluster's cadata build from member cluster's serviceaccount, it work well when kubefed directlly conntect to member cluster. In my case, kubefed connect to a proxyserver (it proxy all apiserver's traffic), and the proxyserver has a independent cabundle.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: