This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: retry on recoverable propagation failure #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
zqzten
force-pushed
the
fix/retry_on_propagation_failure
branch
from
5de19c2
to
a60e9bc
Compare
k8s-ci-robot
added
size/M
zqzten
force-pushed
the
fix/retry_on_propagation_failure
branch
from
a60e9bc
to
3163aad
Compare
zqzten
changed the title
zqzten
force-pushed
the
fix/retry_on_propagation_failure
branch
from
3163aad
to
6e7d14b
Compare
k8s-ci-robot
added
size/S
|
Thanks! /lgtm |
|
/assign @irfanurrehman |
|
Thanks @zqzten for doing this. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irfanurrehman, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently sync controller won't retry propagting a fed resource on any propagation failure, it's not resonable for some recoverable failures such as quota exceed, lack of permissions, etc. For the quota case, after we expand the quota for the failed cluster, we expect KubeFed to automatically succeed in propagating rather than manually edit the fed resource (which is meaninglessly) to trigger a reconciliation.
This PR enable sync controller to retry with back off on recoverable propagation failure.