Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: retry on recoverable propagation failure #1428

Conversation

zqzten
Copy link
Contributor

@zqzten zqzten commented Jun 17, 2021

What this PR does / why we need it:
Currently sync controller won't retry propagting a fed resource on any propagation failure, it's not resonable for some recoverable failures such as quota exceed, lack of permissions, etc. For the quota case, after we expand the quota for the failed cluster, we expect KubeFed to automatically succeed in propagating rather than manually edit the fed resource (which is meaninglessly) to trigger a reconciliation.

This PR enable sync controller to retry with back off on recoverable propagation failure.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot requested review from font and xunpan June 17, 2021 06:47
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2021
@zqzten zqzten force-pushed the fix/retry_on_propagation_failure branch from 5de19c2 to a60e9bc Compare June 18, 2021 05:24
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2021
@zqzten zqzten force-pushed the fix/retry_on_propagation_failure branch from a60e9bc to 3163aad Compare June 18, 2021 05:27
@zqzten zqzten changed the title fix: retry on propagation failure fix: retry on recoverable propagation failure Jun 18, 2021
@zqzten zqzten force-pushed the fix/retry_on_propagation_failure branch from 3163aad to 6e7d14b Compare June 22, 2021 12:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@zqzten
Copy link
Contributor Author

zqzten commented Jun 23, 2021

friendly ping @font @xunpan for a review

@xunpan
Copy link
Contributor

xunpan commented Jun 23, 2021

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@zqzten
Copy link
Contributor Author

zqzten commented Jun 23, 2021

/assign @irfanurrehman

@irfanurrehman
Copy link
Contributor

Thanks @zqzten for doing this.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irfanurrehman, zqzten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit a89eae2 into kubernetes-retired:master Jun 23, 2021
@zqzten zqzten deleted the fix/retry_on_propagation_failure branch June 23, 2021 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants