Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

upgrade github.com/evanphx/json-patch to v4.12.0 #1467

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

zqzten
Copy link
Contributor

@zqzten zqzten commented Oct 27, 2021

What this PR does / why we need it:
This PR upgrades github.com/evanphx/json-patch to v4.12.0 which includes fix evanphx/json-patch#146 in order to fix a panic when KubeFed controller reconcile a federated object with negative array index in its overrides.
This upgrade also enables full support on negative array indice in overrides.

Which issue(s) this PR fixes:
Fixes #1466

Fix partial negative indice support in json patch
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2021
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@zqzten
Copy link
Contributor Author

zqzten commented Oct 27, 2021

Seems like the test failed due to some irrevelant issue.. @hectorj2f Mind rerun the test? Thanks.

@jimmidyson
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, zqzten

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2fc7e36 into kubernetes-retired:master Nov 2, 2021
@zqzten zqzten deleted the upgrade_json_patch branch November 2, 2021 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeFed controller crash when meeting negative array index in overrides
4 participants