Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add kubelet tag in task of Fetch facts to avoid kubelet config inconsistencies #10423

Conversation

NierYYDS
Copy link
Contributor

@NierYYDS NierYYDS commented Sep 9, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:
When I ran playbook with option --tags=kubelet to update kubelet config, I found that some other configurations have been unintentionally modified. In my case, resolvConf was changed from /run/systemd/resolve/resolv.conf to /etc/resolv.conf

< resolvConf: "/etc/resolv.conf"
---
> resolvConf: "/run/systemd/resolve/resolv.conf"

I added a debug task before task(Write kubelet config file) and discovered that the variable kube_resolv_conf was't set to /run/systemd/resolve/resolv.conf.

TASK [kubernetes/node : debug] 
ok: [node1] => {
    "kube_resolv_conf": "/etc/resolv.conf"
}

After reviewing the relevant code, I found in role of kubernetes/node, some variables are overrided during task(Fetch facts), which will be used in later tasks.
So I add a tag kubelet in task(Fetch facts), and re-run the playbook, finally the obtained configurations are correct.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: add kubelet tag in task of Fetch facts to avoid kubelet config inconsistencies

…nconsistencies

when people run playbook with option `--tags=kubelet`, the kubelet config may changed, because some variables used in task populating `kubelet-config.yml`  could be different with running task(`Fetch facts`)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @NierYYDS. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and very good explanation! :)
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @NierYYDS

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, NierYYDS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit af8210d into kubernetes-sigs:master Sep 11, 2023
59 checks passed
@floryut floryut added the kind/bug Categorizes issue or PR as related to a bug. label Sep 18, 2023
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
…nconsistencies (kubernetes-sigs#10423)

when people run playbook with option `--tags=kubelet`, the kubelet config may changed, because some variables used in task populating `kubelet-config.yml`  could be different with running task(`Fetch facts`)
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…nconsistencies (kubernetes-sigs#10423)

when people run playbook with option `--tags=kubelet`, the kubelet config may changed, because some variables used in task populating `kubelet-config.yml`  could be different with running task(`Fetch facts`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants