-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add kubelet tag in task of Fetch facts to avoid kubelet config inconsistencies #10423
fix: add kubelet tag in task of Fetch facts to avoid kubelet config inconsistencies #10423
Conversation
…nconsistencies when people run playbook with option `--tags=kubelet`, the kubelet config may changed, because some variables used in task populating `kubelet-config.yml` could be different with running task(`Fetch facts`)
Hi @NierYYDS. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and very good explanation! :)
/lgtm
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @NierYYDS
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, mzaian, NierYYDS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nconsistencies (kubernetes-sigs#10423) when people run playbook with option `--tags=kubelet`, the kubelet config may changed, because some variables used in task populating `kubelet-config.yml` could be different with running task(`Fetch facts`)
…nconsistencies (kubernetes-sigs#10423) when people run playbook with option `--tags=kubelet`, the kubelet config may changed, because some variables used in task populating `kubelet-config.yml` could be different with running task(`Fetch facts`)
What type of PR is this?
What this PR does / why we need it:
When I ran playbook with option
--tags=kubelet
to update kubelet config, I found that some other configurations have been unintentionally modified. In my case,resolvConf
was changed from/run/systemd/resolve/resolv.conf
to/etc/resolv.conf
I added a debug task before task(
Write kubelet config file
) and discovered that the variablekube_resolv_conf
was't set to/run/systemd/resolve/resolv.conf
.After reviewing the relevant code, I found in role of
kubernetes/node
, some variables are overrided during task(Fetch facts
), which will be used in later tasks.So I add a tag kubelet in task(
Fetch facts
), and re-run the playbook, finally the obtained configurations are correct.Special notes for your reviewer:
Does this PR introduce a user-facing change?: