Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vsphere_csi] update to 3.1.0 #10451

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Sep 19, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR updates the vsphere CSI to 3.1.0 also some conditional support for 2.7.x
Also supports Kubernetes Version 1.28 see: https://github.com/kubernetes-sigs/vsphere-csi-driver/releases/tag/v3.1.0
Fixes #10442

Does this PR introduce a user-facing change?:

[vsphere_csi] Update to 3.1.0 supports Kubernetes Version 1.28

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Sep 19, 2023

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2023
@mzaian mzaian changed the title WIP [vsphere_csi] update to 3.1.0 [vsphere_csi] update to 3.1.0 Sep 19, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Sep 19, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@yankay
Copy link
Member

yankay commented Sep 20, 2023

Thanks @mzaian
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit bc5e337 into kubernetes-sigs:master Sep 20, 2023
59 checks passed
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@ValeriiKretinin
Copy link
Contributor

Hello @mzaian @yankay ! Could you please tell me why env section was deleted in csi-provisioner container spec?
I tried to find the reason on my own, but I couldn't figure it out, I would really appreciate an explanation

@mzaian
Copy link
Contributor Author

mzaian commented Nov 27, 2023

Hello @mzaian @yankay ! Could you please tell me why env section was deleted in csi-provisioner container spec? I tried to find the reason on my own, but I couldn't figure it out, I would really appreciate an explanation

Hello @ValeriiKretinin
I cannot really remember why I removed it. When I checked the vanilla manifests I can see that it does exist. Do you want to create a PR to restore it or should I?

@ValeriiKretinin
Copy link
Contributor

@mzaian I created PR, but I'm not sure about this section that was deleted too:
{% if vsphere_csi_controller is version('v2.2.0', '>=') %}
Should I revert it too?

@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vSphere CSI Driver 3.0.2: "flag provided but not defined: -use-gocsi"
4 participants